New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `dox` feature #193

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Oct 18, 2017

Part of gtk-rs/gir#467

@GuillaumeGomez not fully tested as cairo-sys-rs don't builds on Windows due x11 build script error on pkgconfig call.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 18, 2017

Member

Well, seems good. I can't check for now so if it breaks builds, it'll be time to fix. :p

Member

GuillaumeGomez commented Oct 18, 2017

Well, seems good. I can't check for now so if it breaks builds, it'll be time to fix. :p

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 18, 2017

Member

.. but at minimum cairo-sys-rs/Cargo.toml need fix to document anyway.
I tried dox = ["x11"]

Member

EPashkin commented Oct 18, 2017

.. but at minimum cairo-sys-rs/Cargo.toml need fix to document anyway.
I tried dox = ["x11"]

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 18, 2017

Member

As I understand no way fix this error when build on Windows (x11 uses https://github.com/joshtriplett/metadeps in build script and it can't be ignored).
So I hope that windows dependencies won't be problem.

Member

EPashkin commented Oct 18, 2017

As I understand no way fix this error when build on Windows (x11 uses https://github.com/joshtriplett/metadeps in build script and it can't be ignored).
So I hope that windows dependencies won't be problem.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 18, 2017

Member

I think it'll. Isn't cairo supposed to work on windows? :-/

Member

GuillaumeGomez commented Oct 18, 2017

I think it'll. Isn't cairo supposed to work on windows? :-/

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 18, 2017

Member

It works, but dox feature activate functions with https://github.com/gtk-rs/cairo/blob/master/cairo-sys-rs/src/lib.rs#L541
so crate x11 also need activation or errors for undefined xlib::* appeared.

Member

EPashkin commented Oct 18, 2017

It works, but dox feature activate functions with https://github.com/gtk-rs/cairo/blob/master/cairo-sys-rs/src/lib.rs#L541
so crate x11 also need activation or errors for undefined xlib::* appeared.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Oct 21, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 21, 2017

Member

Is it good to go then?

Member

GuillaumeGomez commented Oct 21, 2017

Is it good to go then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 21, 2017

Member

For safety better wait while it merged and crated, next I need fix cairo to use it.
Or if current PR allow cargo doc --features="dox embed-lgpl-docs" normally on non windows you can merge it
and I start adding PRs for gtk and sourceview

Member

EPashkin commented Oct 21, 2017

For safety better wait while it merged and crated, next I need fix cairo to use it.
Or if current PR allow cargo doc --features="dox embed-lgpl-docs" normally on non windows you can merge it
and I start adding PRs for gtk and sourceview

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 21, 2017

Member

Ok, once this one merged, I'll make a new release (unless you have other things you want to be merged first?).

Member

GuillaumeGomez commented Oct 21, 2017

Ok, once this one merged, I'll make a new release (unless you have other things you want to be merged first?).

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 21, 2017

Member

Gtk, Sourceview need update before release, maybe pangocairo too (not sure how you planing build doc for it)

Member

EPashkin commented Oct 21, 2017

Gtk, Sourceview need update before release, maybe pangocairo too (not sure how you planing build doc for it)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 21, 2017

Member

I'll make those updates then. For pangocairo, the docs are already available, no?

Member

GuillaumeGomez commented Oct 21, 2017

I'll make those updates then. For pangocairo, the docs are already available, no?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 21, 2017

Member

I forgot that it don't have features, then ignore pangocairo.

Member

EPashkin commented Oct 21, 2017

I forgot that it don't have features, then ignore pangocairo.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 22, 2017

Member

Hm, seems I forgot post this yesterday :(

For safety better wait while it merged and crated, next I need fix cairo to use it.
Or if current PR allow cargo doc --features="dox embed-lgpl-docs" normally on non windows you can merge it

Member

EPashkin commented Oct 22, 2017

Hm, seems I forgot post this yesterday :(

For safety better wait while it merged and crated, next I need fix cairo to use it.
Or if current PR allow cargo doc --features="dox embed-lgpl-docs" normally on non windows you can merge it

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 24, 2017

Member

Can be merged as x11 fixed and gtk-rs/cairo#159 added.

Member

EPashkin commented Oct 24, 2017

Can be merged as x11 fixed and gtk-rs/cairo#159 added.

@GuillaumeGomez GuillaumeGomez merged commit e524f70 into gtk-rs:master Oct 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin referenced this pull request Oct 26, 2017

Merged

Update CIs #585

@EPashkin EPashkin deleted the EPashkin:dox branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment