Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EventMotion function #223

Merged
merged 1 commit into from Jun 30, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jun 30, 2018

Fixes #222.

cc @sdroege @EPashkin

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jun 30, 2018

PR looks good itself, but strange, appveyor failing on gio.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jun 30, 2018

That's super weird. O.o

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jun 30, 2018

Unrelated to this PR, it's from the subprocess PR. For some reason it goes into the Unix code paths on Windows, so something needs to be changed there

This PR is fine and can be merged

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jun 30, 2018

Yes, I'm looking at the gio code right now trying to understand what's going on.

Thanks for reviews!

@GuillaumeGomez GuillaumeGomez merged commit 5bdf96f into gtk-rs:master Jun 30, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:event-motion branch Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.