Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #228

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 10, 2018

cc @gkoz @sdroege

}

#[test]
fn check_extern_crates() {

This comment has been minimized.

@EPashkin

EPashkin Jul 11, 2018

Member

Name not match

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 11, 2018

@GuillaumeGomez You right this really needed.
IMHO better publish this as separate lib-crate for checking toml array sorting and use it in test.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 11, 2018

That was my thought too. Just wanted to confirm it before making a new crate. ;)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 11, 2018

@EPashkin better like this? If everything is fine with you, I'll squash then merge.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 11, 2018

@GuillaumeGomez Ops, I forgot send this at morning: you seems lost Gir.toml check completely.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 11, 2018

@EPashkin Oh damn, forgot to add the test... Should be fixed now.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 11, 2018

@GuillaumeGomez Yes, it works now locally.
Thanks and 👍 for merge

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 11, 2018

Time for squash then! :)

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:test2 branch from 3374660 to 22aab59 Jul 11, 2018

@GuillaumeGomez GuillaumeGomez merged commit 6cd3801 into gtk-rs:master Jul 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:test2 branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.