New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parent #237

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Aug 24, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 24, 2018

Member

Thanks, 👍 after CI.
But it have strange error on nightly, maybe it be fixed by restarting job

Member

EPashkin commented Aug 24, 2018

Thanks, 👍 after CI.
But it have strange error on nightly, maybe it be fixed by restarting job

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 24, 2018

Member

Weird indeed... I restarted it.

Member

GuillaumeGomez commented Aug 24, 2018

Weird indeed... I restarted it.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 24, 2018

Member
error[E0432]: unresolved import `gio_ffi`
 --> src/auto/app_launch_context.rs:9:5
  |
9 | use gio_ffi;
  |     ^^^^^^^ no `gio_ffi` in the root. Did you mean to use `glib_ffi`?
Member

EPashkin commented Aug 24, 2018

error[E0432]: unresolved import `gio_ffi`
 --> src/auto/app_launch_context.rs:9:5
  |
9 | use gio_ffi;
  |     ^^^^^^^ no `gio_ffi` in the root. Did you mean to use `glib_ffi`?
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 24, 2018

Member

👍

Member

sdroege commented Aug 24, 2018

👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 24, 2018

Member

Thanks for your reviews!

Member

GuillaumeGomez commented Aug 24, 2018

Thanks for your reviews!

@GuillaumeGomez GuillaumeGomez merged commit 28829be into gtk-rs:master Aug 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:missing-parent branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment