Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define manual traits #265

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 27, 2019

Part of gtk-rs/gir#683 and gtk-rs/gir#655

gtk-rs/gio#184 and gtk-rs/gtk#766 will fail regen check,
not sure what better to do with them.

cc @GuillaumeGomez, @sdroege

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 27, 2019

Not sure either...

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 27, 2019

CI passed

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 27, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 28, 2019

👍

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from e62f696 to ae90823 Jan 29, 2019

@EPashkin EPashkin changed the title Define manual traits and fix gdk_cursor_new_from_name Define manual traits Jan 29, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 29, 2019

This IMHO ready for merge. While check init assert still failing it not related to this PR.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 29, 2019

Seems good. CI won't break nor check for this so I'll just check.

@GuillaumeGomez GuillaumeGomez merged commit 8043952 into gtk-rs:master Jan 29, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@EPashkin EPashkin deleted the EPashkin:manual_traits branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.