Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't box closures twice #266

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Jan 28, 2019

No description provided.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 28, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 28, 2019

$ ./check_init_asserts
src/event.rs:set_handler(ptr: glib_ffi::gpointer) 
The command "./check_init_asserts" exited with 1.
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 28, 2019

What does that mean? :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 28, 2019

I don't know, probably old check_init_asserts(gtks check different names), or it bad with closures.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 28, 2019

I don't know, probably old check_init_asserts(gtks check different names), or it bad with closures.

Ok but this is nothing new from my PR so let's worry about that another time :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 28, 2019

Agree.
Script fails on new event_handler_destroy and event_handler_trampoline and want assert macro here.
Seems constraint broke regex

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 28, 2019

@GuillaumeGomez good to go :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 28, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 4f00bda into gtk-rs:master Jan 28, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.