Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields have been generated so we can uncommented those methods #285

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Mar 18, 2019

// from_glib(self.as_ref().is_modifier)
// }
pub fn get_is_modifier(&self) -> bool {
self.as_ref().is_modifier != 0

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 18, 2019

Member

Its bitfield, so IMHO better something like self.as_ref().is_modifier & 1 != 0,
same for is_stop

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:events branch from 13e367c to 882c89b Mar 18, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Updated.

@@ -1,2 +1,2 @@
Generated by gir (https://github.com/gtk-rs/gir @ 914ca73)
Generated by gir (https://github.com/gtk-rs/gir @ 1ae7210)

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 18, 2019

Member

This file changed but submodule not updated.

@@ -4,6 +4,7 @@

use gdk_sys;
use glib::translate::*;
use libc;

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 18, 2019

Member

IMHO this use not used.

This comment has been minimized.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 18, 2019

Author Member

No it wasn't. Weird that I added it... Good catch!

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:events branch from 882c89b to 14609a0 Mar 18, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Updated.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Thanks, 👍

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

👍

@GuillaumeGomez GuillaumeGomez merged commit 3e2bf6d into gtk-rs:master Mar 19, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:events branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.