Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traits for disguised types without children #291

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented May 11, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented May 11, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Is it ready or not yet? (Same question for all same PRs)

Otherwise the current code looks good to me.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Oh and the diff is failing.

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

It not ready because gir's part not merged.
As my PR is small I prefer merge it after your PR, @antoyo's and "edition2018",
to make full regen

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Makes sense!

@EPashkin EPashkin force-pushed the EPashkin:fix_disguised_final_types branch from bcfa44a to 51813d2 May 17, 2019

@EPashkin EPashkin force-pushed the EPashkin:fix_disguised_final_types branch from 51813d2 to 4d1e48f May 17, 2019

@EPashkin EPashkin changed the title WIP: Remove traits for disguised types without children Remove traits for disguised types without children May 17, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 8764649 into gtk-rs:master May 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_disguised_final_types branch May 21, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented May 21, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@EPashkin Can you reopen this PR please? I removed this commit by mistake (sorry). :-/

@EPashkin EPashkin restored the EPashkin:fix_disguised_final_types branch Jun 8, 2019

@EPashkin EPashkin deleted the EPashkin:fix_disguised_final_types branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.