Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo interactions: auto load Pixbuf & Surface Exts #309

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@bilelmoussaoui
Copy link
Contributor

bilelmoussaoui commented Aug 12, 2019

Part 1 of #308

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 13, 2019

I don't understand the need for these changes, even after reading the issue...

@bilelmoussaoui

This comment has been minimized.

Copy link
Contributor Author

bilelmoussaoui commented Aug 13, 2019

Because its currently impossible to use those functions. Some need to be moved out Of the ContextExt which I want to send as a different PR

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 13, 2019

Even if you import the traits in your code? Can you show us an example with the problematic code please?

@bilelmoussaoui

This comment has been minimized.

Copy link
Contributor Author

bilelmoussaoui commented Aug 13, 2019

Without this patch I can't draw on a surface and restore the latest surface which is used on drawing user selected rectangle see https://gitlab.gnome.org/bilelmoussaoui/censor/blob/df8807078d50daf9aa3c2a631c0a4c1515a6d914/src/widgets/drawer.rs#L161 the code is a bit messy for now

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

The change is correct, the traits must all be exported from the prelude like all other traits.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 14, 2019

Makes sense indeed. Thanks @bilelmoussaoui !

@GuillaumeGomez GuillaumeGomez merged commit 8ea697f into gtk-rs:master Aug 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui:cairo-prelude branch Aug 14, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

@GuillaumeGomez or @bilelmoussaoui can you create an issue here https://github.com/gtk-rs/gtk4/issues or a PR for doing the same change?

@bilelmoussaoui

This comment has been minimized.

Copy link
Contributor Author

bilelmoussaoui commented Aug 14, 2019

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.