Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix up cairo interaction extension traits #312
- Remove duplicated ContextExt::cairo_surface_create_from_pixbuf(). It already exists as PixbufExt::create_surface() - Rename ContextExt::cairo_draw_from_gl() to draw_from_gl() and take the context as &self - Mark ContextExt::draw_from_gl as unsafe! It takes random integers for GL resources, which are basically like pointers and must be taken care of to be correct and valid. - Change all functions taking a gdk::Window to take a IsA<gdk::Window> - Rename all traits to include the Gdk prefix for preventing naming conflicts. Fixes #308
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.