New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out gdk-pixbuf #98

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Feb 9, 2016

cc @gkoz

Needs gdk-pixbuf's PR to be merged before.

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Feb 9, 2016

Member

The prelude build error suggests that the gdk-pixbuf needs its own, which could then be blanketly reexported in this crate's prelude.

Member

gkoz commented Feb 9, 2016

The prelude build error suggests that the gdk-pixbuf needs its own, which could then be blanketly reexported in this crate's prelude.

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Feb 9, 2016

Member

Or rather, let's not do the prelude reexport yet. I might prefer to do the reexporting once in gtk.

Member

gkoz commented Feb 9, 2016

Or rather, let's not do the prelude reexport yet. I might prefer to do the reexporting once in gtk.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2016

Member

And updated as well (but the build won't work until gdk-pixbuf's PR is merged).

Member

GuillaumeGomez commented Feb 9, 2016

And updated as well (but the build won't work until gdk-pixbuf's PR is merged).

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2016

Member

I restarted appveyor and travis.

Member

GuillaumeGomez commented Feb 9, 2016

I restarted appveyor and travis.

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Feb 9, 2016

Member

The appveyor build has passed.

Member

gkoz commented Feb 9, 2016

The appveyor build has passed.

gkoz added a commit that referenced this pull request Feb 9, 2016

@gkoz gkoz merged commit 8c5ebb8 into gtk-rs:master Feb 9, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment