New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cancellable::reset() #104

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@sdroege
Member

sdroege commented Apr 9, 2018

commit c48c9a8 (HEAD -> cancellable-no-reset)
Author: Sebastian Dröge sebastian@centricular.com
Date: Mon Apr 9 18:19:26 2018 +0200

Remove Cancellable::reset()

It can easily cause undefined behaviour, see
https://github.com/gtk-rs/gio/pull/102#issuecomment-379690071

sdroege added some commits Apr 8, 2018

Remove Cancellable::reset()
It can easily cause undefined behaviour, see
#102 (comment)
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 10, 2018

Member

@GuillaumeGomez Let's get that in then?

Member

sdroege commented Apr 10, 2018

@GuillaumeGomez Let's get that in then?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 10, 2018

Member

Sorry, missed this one. Thanks!

Member

GuillaumeGomez commented Apr 10, 2018

Sorry, missed this one. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b02d894 into gtk-rs:master Apr 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment