Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Source related cleanups and add PollableInputStream/PollableOutputStream #106

Merged
merged 3 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Apr 16, 2018

No description provided.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Apr 16, 2018

Build failure is because of gtk-rs/glib#312

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 16, 2018

Restarting ci.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Apr 16, 2018

First that other PR has to be fixed :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Apr 17, 2018

Fixed a safety problem here in the new commit.

@sdroege sdroege force-pushed the sdroege:sources branch 2 times, most recently from 8466267 to 84837b0 Apr 17, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 17, 2018

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Apr 17, 2018

@EPashkin Fix how? #107 ?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 17, 2018

Yes, I was don't done reading all mails 😉

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 19, 2018

@GuillaumeGomez Sorry, but can you restart CI here too, it part of #108 and has more chance to pass CI

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Apr 19, 2018

yes this one should go in asap :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 19, 2018

Restarted.

sdroege added some commits Apr 16, 2018

Add PollableInputStream and PollableOutputStream
And remove g_pollable_source_new() binding, it's part of the interfaces
and not really useful by itself.
Remove g_cancellable_source_new
It would need manual bindings to set the source callback, etc and is not
very useful on its own.
Use SendCell to prevent Socket/Pollable*Stream to move to other threa…
…ds via the GSource

And mark the closure as non-Send too.

@sdroege sdroege force-pushed the sdroege:sources branch from 84837b0 to 28ffb32 Apr 19, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 20, 2018

@GuillaumeGomez it only same rawfd error on travis, IMHO ready for merge.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 20, 2018

I really need to fix glib...

@GuillaumeGomez GuillaumeGomez merged commit ee51a57 into gtk-rs:master Apr 20, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#106 from sdroege/sources
Various Source related cleanups and add PollableInputStream/PollableOutputStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.