New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid main context interference when running async tests. #107

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@tmiasko
Contributor

tmiasko commented Apr 17, 2018

  • Create separate context for each invocation instead of using global one.
  • Configure thread default context before invoking closure so that
    operations will be executed in correct context.
  • Avoid creating additional threads, they are unnecessary.

Fixes issue #93

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

👍

Member

sdroege commented Apr 17, 2018

👍

Show outdated Hide outdated src/test_util.rs
Avoid main context interference when running async tests.
* Create separate context for each invocation instead of using global one.
* Configure thread default context before invoking closure so that
  operations will be executed in correct context.
* Avoid creating additional threads, they are unnecessary.

Fixes issue #93
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

@GuillaumeGomez Let's get this in then, together with Phil's PR this should solve most of the failures

Member

sdroege commented Apr 17, 2018

@GuillaumeGomez Let's get this in then, together with Phil's PR this should solve most of the failures

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 17, 2018

Member

Agreed. Just waiting for CIs. :)

Member

GuillaumeGomez commented Apr 17, 2018

Agreed. Just waiting for CIs. :)

@GuillaumeGomez GuillaumeGomez merged commit b6bf3d4 into gtk-rs:master Apr 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tmiasko tmiasko deleted the tmiasko:separate-context-in-tests branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment