Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build docs for non unix (second attempt) #116

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Copy link
Member

EPashkin commented Apr 24, 2018

Fix error found on building docs in gtk-rs/gdk#194

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 24, 2018

Aaaaaaah! Now I see! But isn't it strange that windows build is just working fine already?

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Apr 24, 2018

unix_socket_address.rs included only on unix or dox

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 24, 2018

Yes, so windows build should fail from the appveyor config file.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Apr 24, 2018

Seems cargo doc uses some optimization on current crate and skip processing function bodies,
this only explanation of this behavior that come in my mind.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 24, 2018

I suppose... But it shouldn't. Well whatever, as long as it works!

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Apr 24, 2018

CI passed

@GuillaumeGomez GuillaumeGomez merged commit 62e5c5d into gtk-rs:master Apr 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Apr 24, 2018

Let's check on gdk now! :)

@EPashkin EPashkin deleted the EPashkin:fix_dox_for_windows_2 branch Apr 24, 2018

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#116 from EPashkin/fix_dox_for_windows_2
Fix build docs for non unix (second attempt)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.