New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OsString support and regen #118

Merged
merged 4 commits into from May 18, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 9, 2018

@tmiasko

This comment has been minimized.

Show comment
Hide comment
@tmiasko

tmiasko May 9, 2018

Contributor

Upstream annotations seem to be incorrect for g_unix_is_system_device_path and
g_unix_is_system_fs_type. Those probably should accept path / filename
arguments.

Everything else looks great, thanks!

Contributor

tmiasko commented May 9, 2018

Upstream annotations seem to be incorrect for g_unix_is_system_device_path and
g_unix_is_system_fs_type. Those probably should accept path / filename
arguments.

Everything else looks great, thanks!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@tmiasko By test from gio source, seems it just string.

static void
test_is_system_fs_type (void)
{
  g_assert_true (g_unix_is_system_fs_type ("tmpfs"));
  g_assert_false (g_unix_is_system_fs_type ("ext4"));
}

Member

EPashkin commented May 9, 2018

@tmiasko By test from gio source, seems it just string.

static void
test_is_system_fs_type (void)
{
  g_assert_true (g_unix_is_system_fs_type ("tmpfs"));
  g_assert_false (g_unix_is_system_fs_type ("ext4"));
}

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@tmiasko, I looked wrong function :( So you right.

static void
test_is_system_device_path (void)
{
  g_assert_true (g_unix_is_system_device_path ("devpts"));
  g_assert_false (g_unix_is_system_device_path ("/"));
}
Member

EPashkin commented May 9, 2018

@tmiasko, I looked wrong function :( So you right.

static void
test_is_system_device_path (void)
{
  g_assert_true (g_unix_is_system_device_path ("devpts"));
  g_assert_false (g_unix_is_system_device_path ("/"));
}
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

Updated

Member

EPashkin commented May 9, 2018

Updated

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 10, 2018

Member

I restarted Apveyor.
@GuillaumeGomez Please, restart travis too.

Member

EPashkin commented May 10, 2018

I restarted Apveyor.
@GuillaumeGomez Please, restart travis too.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 10, 2018

Member

Restarted.

Member

GuillaumeGomez commented May 10, 2018

Restarted.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 10, 2018

Member

Again all passed except single Travis build (due nightly futures)

Member

EPashkin commented May 10, 2018

Again all passed except single Travis build (due nightly futures)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 10, 2018

Member

Then it's good enough for me. Thanks @EPashkin! :)

Member

GuillaumeGomez commented May 10, 2018

Then it's good enough for me. Thanks @EPashkin! :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 18, 2018

Member

@GuillaumeGomez Seems this PR ready for merge, I even forget about it.

Member

EPashkin commented May 18, 2018

@GuillaumeGomez Seems this PR ready for merge, I even forget about it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 18, 2018

Member

Weird I forgot it as well... Sorry about that...

Member

GuillaumeGomez commented May 18, 2018

Weird I forgot it as well... Sorry about that...

@GuillaumeGomez GuillaumeGomez merged commit efc6c90 into gtk-rs:master May 18, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:os_string branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment