New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSettingsSchemaSource bindings #121

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jun 5, 2018

Fixes #120

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 5, 2018

Member

Looks good to me.

Member

GuillaumeGomez commented Jun 5, 2018

Looks good to me.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 6, 2018

Member

@sdroege Thanks, but there changes in src/auto/versions.txt but no submodule update.

Member

EPashkin commented Jun 6, 2018

@sdroege Thanks, but there changes in src/auto/versions.txt but no submodule update.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 6, 2018

Member

IMHO simpler just remove versions.txt changes, code generated with current submodules is same

Member

EPashkin commented Jun 6, 2018

IMHO simpler just remove versions.txt changes, code generated with current submodules is same

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 6, 2018

Member

Done, removed the version.txt changes

Member

sdroege commented Jun 6, 2018

Done, removed the version.txt changes

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 6, 2018

Member

@GuillaumeGomez should be good to go then :) Was green on CI before I removed the version.txt change

Member

sdroege commented Jun 6, 2018

@GuillaumeGomez should be good to go then :) Was green on CI before I removed the version.txt change

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 6, 2018

Member

Not fully green, but we can do nothing with futures-core :(

Member

EPashkin commented Jun 6, 2018

Not fully green, but we can do nothing with futures-core :(

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 6, 2018

Member

Right, see rust-lang-nursery/futures-rs#1031. Not much we can do about that other than removing the futures-nightly build from CI for now

Member

sdroege commented Jun 6, 2018

Right, see rust-lang-nursery/futures-rs#1031. Not much we can do about that other than removing the futures-nightly build from CI for now

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 6, 2018

Member

Then I merge. Thanks!

Member

GuillaumeGomez commented Jun 6, 2018

Then I merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 322e087 into gtk-rs:master Jun 6, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment