Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new types #133

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 4, 2018

@EPashkin
Copy link
Member

EPashkin left a comment

Looks good, only one object IMHO better removed

use std::ptr;

glib_wrapper! {
pub struct NativeVolumeMonitor(Object<ffi::GNativeVolumeMonitor, ffi::GNativeVolumeMonitorClass>): VolumeMonitor;

This comment has been minimized.

@EPashkin

EPashkin Jul 5, 2018

Member

This class unusable without GUnixVolumeMonitor and GWin32VolumeMonitor,
and there no docs for it or public constructors (Ex. _g_unix_volume_monitor_new start with underscore),
so maybe this classes don't intended for external use,

This comment has been minimized.

@sdroege

sdroege Jul 5, 2018

Member

It's also not in gtk-doc, seems like a mistake that it is in the gir file (also the unix/win32 ones shouldn't)

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jul 5, 2018

Author Member

Ah interesting. I was able to find it in the gnome docs but it basically does nothing. I'll remove it.

}

pub trait ProxyAddressExt {
fn get_destination_hostname(&self) -> Option<String>;

This comment has been minimized.

@sdroege

sdroege Jul 5, 2018

Member

This can't be NULL AFAIU


fn get_password(&self) -> Option<String>;

fn get_protocol(&self) -> Option<String>;

This comment has been minimized.

@sdroege

sdroege Jul 5, 2018

Member

Neither can this be NULL

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 5, 2018

Looks good apart from the above. I thought I added the proxy things with the sockets back then, seems I started and forgot to finish that :)

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:new-types-4 branch from 3ea1db6 to 8680390 Jul 5, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 5, 2018

Updated.

fn get_destination_port(&self) -> u16;

#[cfg(any(feature = "v2_34", feature = "dox"))]
fn get_destination_protocol(&self) -> Option<String>;

This comment has been minimized.

@EPashkin

EPashkin Jul 5, 2018

Member

This IMHO also not-nullable

This comment has been minimized.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 5, 2018

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 5, 2018

ok :)

@GuillaumeGomez GuillaumeGomez merged commit 61ae11d into gtk-rs:master Jul 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:new-types-4 branch Jul 5, 2018

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.