Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors on armv7l for desktop_app_info.rs and unix_socket_add… #138

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@meldron
Copy link

meldron commented Jul 23, 2018

This PR fixes compile errors on armv7l (raspberry pi), see issue #137.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 23, 2018

If you could add a check for this on travis, it'd be awesome!

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

Ugh, I just sent a PR for the same here #139 :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 23, 2018

I was about to comment about it. XD

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

Looks good to me if that also works. I'll update my PR after this is merged to only include 83e979c

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

If you could add a check for this on travis, it'd be awesome!

That's not too trivial, can we do that in a separate PR?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

Updated my PR to only have that one commit

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

@meldron please add

Fixes https://github.com/gtk-rs/gio/issues/137

to the commit message at the bottom in a new line

@meldron meldron force-pushed the meldron:armv7l-type-fixes branch from 27c6256 to 389aa34 Jul 23, 2018

@meldron

This comment has been minimized.

Copy link
Author

meldron commented Jul 23, 2018

@sdroege I added that line to the bottom.

Thanks a lot for your great help and awesome response time.

@GuillaumeGomez I have not added any tests yet, because I am unsure how you would like to test this.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 23, 2018

@meldron I discussed about it with @sdroege and it's gonna be tricky (a qemu instance very certainly...). So just forget about it for now.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

@meldron I discussed about it with @sdroege and it's gonna be tricky (a qemu instance very certainly...). So just forget about it for now.

You can also cross-compile if you somehow get all the libraries needed (GTK, etc) for arm. Not sure if the ancient Ubuntu on travis already had proper multiarch support, in newer Ubuntu/Debian you can easily install those packages for other architectures.

And then you will probably have to fight with pkg-config. In any case, something for another PR.

@meldron

This comment has been minimized.

Copy link
Author

meldron commented Jul 23, 2018

Okay,

thanks for your help guys.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

thanks for your help guys.

No problem, let me know if you run into other problems with the GStreamer bindings on ARM!

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2018

All green

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 23, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6448000 into gtk-rs:master Jul 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#138 from meldron/armv7l-type-fixes
Fix type errors on armv7l for desktop_app_info.rs and unix_socket_add…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.