Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #166

Merged
merged 2 commits into from Oct 27, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 27, 2018

Fixes #165.

cc @EPashkin @sdroege

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 27, 2018

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Oct 27, 2018

This breaks API. Only include that single fix please :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Oct 27, 2018

Arf, ok!

sdroege and others added some commits Oct 8, 2018

Fix compilation of Subprocess::communicate_utf8_async_trampoline() on…
… ARM or other architectures with unsigned C chars

error[E0277]: the trait bound `std::string::String: glib::translate::ToGlibPtr<'_, *mut i8>` is not satisfied
  --> vendor/gio/src/subprocess.rs:40:35
   |
40 |         let stdin_buf = stdin_buf.to_glib_full();
   |                                   ^^^^^^^^^^^^ the trait `glib::translate::ToGlibPtr<'_, *mut i8>` is not implemented for `std::string::String`
   |
   = help: the following implementations were found:
             <std::string::String as glib::translate::ToGlibPtr<'a, *mut u8>>
             <std::string::String as glib::translate::ToGlibPtr<'a, *const u8>>
   = note: required because of the requirements on the impl of `glib::translate::ToGlibPtr<'_, *mut i8>` for `std::option::Option<std::string::String>`
error[E0308]: mismatched types
  --> vendor/gio/src/subprocess.rs:57:77
   |
57 |             ffi::g_subprocess_communicate_utf8_async(self.to_glib_none().0, stdin_buf, cancellable.0, Some(callback), Box::into_raw(user_data) as *mut _);
   |                                                                             ^^^^^^^^^ expected u8, found i8
   |
   = note: expected type `*const u8`
              found type `*mut i8`

@GuillaumeGomez GuillaumeGomez force-pushed the new-release branch from 3996f6e to d91d722 Oct 27, 2018

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Oct 27, 2018

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 27, 2018

👍 too

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Oct 27, 2018

Thanks to both of you!

@GuillaumeGomez GuillaumeGomez merged commit 361a0c4 into crate Oct 27, 2018

0 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@GuillaumeGomez GuillaumeGomez deleted the new-release branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.