Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gstring support #177

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@philn
Copy link
Contributor

philn commented Dec 16, 2018

No description provided.

@philn philn force-pushed the philn:gstring branch from 9f1e841 to e870fde Dec 16, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 16, 2018

This will also have problems:

  --> D:/eap/rust/0/gio\src\file.rs:62:20
   |
62 |         let etag = etag.into();
   |                    ^^^^^^^^^^^
   |
note: first, the lifetime cannot outlive the lifetime 'a as defined on the method body at 58:5...
  --> D:/eap/rust/0/gio\src\file.rs:58:5
   |
58 |     fn replace_contents_async_future<'a, B: AsRef<[u8]> + Send + 'static, P: Into<Option<&'a str>>>(&self, contents: B, etag: P, make_backup: bool, flags: FileCreateFlags) -> Box<futures_core::Future<Item = (Self, (B, glib::GString)), Error = (Self, (B, Error))>> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: ...so that the expression is assignable:
           expected std::option::Option<&str>
              found std::option::Option<&'a str>
   = note: but, the lifetime must be valid for the static lifetime...
   = note: ...so that the types are compatible:
           expected std::convert::From<&str>
              found std::convert::From<&'static str>

@philn

This comment has been minimized.

Copy link
Contributor Author

philn commented Dec 16, 2018

Hum, the build works here with 1.31 on Linux. How can I reproduce this error?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 16, 2018

I build examples with default uncommented.
Also possible build only gio with feature "futures"

@philn

This comment has been minimized.

Copy link
Contributor Author

philn commented Dec 16, 2018

Ah right, I didn't notice the compile guard. Will try to fix it.

@philn

This comment has been minimized.

Copy link
Contributor Author

philn commented Dec 17, 2018

I think this can land now, can the CI re-run?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 17, 2018

Done

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 17, 2018

@GuillaumeGomez Strange, but I now can rerun\abort travis.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 17, 2018

And CI passed now

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 17, 2018

@GuillaumeGomez Strange, but I now can rerun\abort travis.

Well, that's a great thing!

Thanks @philn!

@GuillaumeGomez GuillaumeGomez merged commit fb65620 into gtk-rs:master Dec 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@philn philn deleted the philn:gstring branch Dec 17, 2018

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.