Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define manual traits #184

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 26, 2019

Part of gtk-rs/gir#683

WIP as I added parent manual traits only up to file_input_stream.rs and trying teach gir do it.

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from 5164974 to 7e5bea8 Jan 26, 2019

@EPashkin EPashkin referenced this pull request Jan 27, 2019

Merged

Define manual traits #265

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from 7e5bea8 to df3ba50 Jan 29, 2019

@EPashkin EPashkin changed the title WIP: Define manual traits Define manual traits Jan 29, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 29, 2019

Rebased

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 29, 2019

This seems ready too

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from df3ba50 to ac9d811 Jan 31, 2019

@EPashkin EPashkin referenced this pull request Jan 31, 2019

Open

Docs don't shows that class implements manual traits #683

1 of 2 tasks complete
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 31, 2019

Looks good to me, will merge once it's done.

We'll also need this for glib, or not? ObjectExt is a manual trait there

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 31, 2019

All good apart from the known failures, so let's get this in!

@sdroege sdroege merged commit 9057418 into gtk-rs:master Jan 31, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:manual_traits branch Jan 31, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 31, 2019

ObjectExt has same name as generated trait.
@GuillaumeGomez I just found that glib don't include lgpl docs.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 31, 2019

Really? I'm a bit surprised...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.