Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable InetAddress{Mask}::equal() and to_string() #188

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Jan 31, 2019

No description provided.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 31, 2019

@sdroege Can you update with latest gir. Or prefer it be in different PR?

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 31, 2019

@sdroege Can you update with latest gir. Or prefer it be in different PR?

@GuillaumeGomez is doing a PR for that already.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 31, 2019

then 👍 Thanks

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 31, 2019

And other PR better based on this, or rebased after merge

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 31, 2019

And other PR better based on this, or rebased after merge

Shouldn't make any difference. The regen PR is not touching any of this, they can be handled independently.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 31, 2019

Not sure about this

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 31, 2019

I tested it :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 31, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 31, 2019

All good to me as well, thanks!

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 31, 2019

All good apart from the 1.28 builds, merging. (@GuillaumeGomez were you not planning to remove the 1.28 builds?)

@sdroege sdroege merged commit c1924dc into gtk-rs:master Jan 31, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.