Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xx_sys to xx_ffi renaming #200

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Mar 5, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

👍

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from 123fc7a to e2459e3 Mar 6, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Updated too

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Why is this WIP? Good to go in any case with the latest version of the gir PR.

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

gir PR is merged now, so let's get this updated and merged? :)

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from e2459e3 to 0666b0b Mar 10, 2019

@EPashkin EPashkin changed the title WIP: Remove xx_sys to xx_ffi renaming Remove xx_sys to xx_ffi renaming Mar 10, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Updated

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from 0666b0b to 0f64c60 Mar 10, 2019

use glib::translate::*;
use glib_ffi;
use glib::GString;

This comment has been minimized.

Copy link
@sdroege

sdroege Mar 10, 2019

Member

How did you get this all re-ordered, if not by rustfmt... but if rustfmt, why isn't everything else nicely formatted too then? :)

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 10, 2019

Author Member

I use rustfmt but stashGed only this part 😉

This comment has been minimized.

Copy link
@sdroege

sdroege Mar 10, 2019

Member

Maybe it's soon time to switch to it completely then ;) Anyway, fine with me to only take this change for now :)

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

CI "passed"

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e05ff1c into gtk-rs:master Mar 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:ffi_to_sys branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.