Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to futures 0.3 #206

Merged
merged 4 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

commented Apr 26, 2019

While this requires nightly, the API is now stabilized and will become part of Rust 1.36. IMHO we should merge this now so that it can all get wider testing.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

This is currently marked as WIP because it uses gtk-rs/glib#476 and gtk-rs/gir#753 via Cargo patching

@sdroege sdroege changed the title Port to Futures 0.3 Port to futures 0.3 Apr 26, 2019

@sdroege sdroege force-pushed the sdroege:futures-0.3 branch from ff86362 to 46f8988 Apr 26, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

I'll also change this to actually run the futures tests on nightly. And send another PR for that for glib.

Otherwise please review this one already but not merge yet.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

I'll also change this to actually run the futures tests on nightly. And send another PR for that for glib.

Added and done

@EPashkin

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@sdroege Thanks. 👍.
Sourceview's auto/search_context.rs also affected by gir changes

@sdroege sdroege force-pushed the sdroege:futures-0.3 branch from a9fe9be to 3800c4d Apr 26, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

So let's get this in and then I do the examples first (they don't need the other crates updated), and then I do gdk-pixbuf, gtk and sourceview.

@sdroege sdroege merged commit 047ea1c into gtk-rs:master Apr 26, 2019

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.