Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gir config for Unix{Input,Output}Stream #208

Merged
merged 3 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@moggiesir
Copy link
Contributor

commented May 6, 2019

I put auto/* files into a separate commit as the docs on gtk-rs/gtk said.

Not sure if there's something to watch for in the generated output, but this worked for connecting a WebKit2.URISchemeRequest.finish to a either a socketpair or unix pipe.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 6, 2019

👍

Show resolved Hide resolved src/auto/unix_input_stream.rs Outdated
Show resolved Hide resolved src/auto/unix_input_stream.rs Outdated
Show resolved Hide resolved src/auto/unix_output_stream.rs Outdated
Show resolved Hide resolved src/auto/unix_output_stream.rs Outdated

@moggiesir moggiesir force-pushed the moggiesir:master branch from f096c2b to 30aa59d May 13, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented May 13, 2019

lgtm, thanks!

@GuillaumeGomez ?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Looks good to me as well, thanks! (and big thanks for the comments in the gir file!)

@sdroege sdroege merged commit 10df4f6 into gtk-rs:master May 13, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.