Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new types #213

Merged
merged 3 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented May 18, 2019

Needs to be regenerated after gtk-rs/gir#774 and gtk-rs/glib#486

cc @sdroege @EPashkin

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

Now just remains gtk-rs/glib#486 and we're good to go.


//fn measure_disk_usage_async<P: IsA<Cancellable>, Q: FnOnce(Result<(u64, u64, u64), Error>) + Send + 'static>(&self, flags: /*Ignored*/FileMeasureFlags, io_priority: glib::Priority, cancellable: Option<&P>, progress_callback: Option<Box<dyn Fn(bool, u64, u64, u64) + 'static>>, callback: Q);
//fn measure_disk_usage_async<P: IsA<Cancellable>, Q: FnOnce(Result<(u64, u64, u64), Error>) + Send + 'static>(&self, flags: FileMeasureFlags, io_priority: glib::Priority, cancellable: Option<&P>, progress_callback: Option<Box<dyn Fn(bool, u64, u64, u64) + 'static>>, callback: Q);

This comment has been minimized.

Copy link
@sdroege

sdroege May 20, 2019

Member

Why is this not generated still? Seems like nothing is actually missing now

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 20, 2019

Author Member

I wonder...

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 21, 2019

Author Member

measure_disk_usage_async: missing success parameters for async future

This comment has been minimized.

Copy link
@sdroege

sdroege May 21, 2019

Member

What does that mean? :)

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 21, 2019

Author Member

Aren't you the one who wrote this part of gir? :p Or maybe @antoyo?

This comment has been minimized.

Copy link
@sdroege

sdroege May 21, 2019

Member

Not me :)

This comment has been minimized.

Copy link
@antoyo

antoyo May 21, 2019

Member

@GuillaumeGomez: Looks like you did it.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 21, 2019

Author Member

Ok, maybe it's on me.... Again... XD

This comment has been minimized.

Copy link
@sdroege

sdroege May 29, 2019

Member

Let's create a gir issue for this then? :)

This comment has been minimized.

Copy link
@GuillaumeGomez
@@ -233,7 +246,7 @@ impl FileInfo {
}
}

//pub fn set_attribute(&self, attribute: &str, type_: /*Ignored*/FileAttributeType, value_p: /*Unimplemented*/Fundamental: Pointer) {
//pub fn set_attribute(&self, attribute: &str, type_: FileAttributeType, value_p: /*Unimplemented*/Fundamental: Pointer) {

This comment has been minimized.

Copy link
@sdroege

sdroege May 20, 2019

Member

Seems like we want some manual implementation for all this file attribute API, that safely exposes this pointer via some trait with an associated type for the different file attribute types

This comment has been minimized.

Copy link
@sdroege

sdroege May 29, 2019

Member

For a later PR

This comment has been minimized.

Copy link
@sdroege

sdroege May 29, 2019

Member

Just keep in mind that the API is kind of useless without

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 29, 2019

Author Member

I'll try to add it as soon as possible.

This comment has been minimized.

Copy link
@sdroege

sdroege May 29, 2019

Member

I think the nice way to implement would be similar to the GStreamer tags support. You'd have a ZST for each attribute that implements a trait, that trait has an associated type for the attribute type and provides ways for getting from such a value to the attribute

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:add-new-types branch from b27675d to e7907bb May 28, 2019

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:add-new-types branch from e7907bb to 0a5380c May 28, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Updated.

@sdroege

This comment has been minimized.

Copy link
Member

commented May 29, 2019

👍

@sdroege sdroege merged commit ad6b6d3 into gtk-rs:master May 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:add-new-types branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.