Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trampolines #218

Merged
merged 3 commits into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

commented Jun 8, 2019

Part of gtk-rs/gir#792

@sdroege sdroege merged commit 3abdf62 into gtk-rs:master Jun 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Will you also do GLib? In object.rs there should be at least one, for the notify signal.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

When I generated, nothing changed?

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:move-trampolines branch Jun 8, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

There's manual code :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Oh you meant updating the manual code! In case a function is used in different places, what should we do? Copy it or keep it "outside"?

@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Not copy :) Keep it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.