Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version #227

Merged
merged 1 commit into from Jul 7, 2019
Merged

New version #227

merged 1 commit into from Jul 7, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Jul 6, 2019

@@ -603,6 +615,12 @@ pub fn unix_is_system_fs_type(fs_type: &str) -> bool {
// unsafe { TODO: call gio_sys:g_unix_mount_get_options() }
//}

//#[cfg(any(unix, feature = "dox"))]
//#[cfg(any(feature = "v2_60", feature = "dox"))]
//pub fn unix_mount_get_root_path(mount_entry: /*Ignored*/&mut UnixMountEntry) -> Option<GString> {

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jul 6, 2019

Author Member

UnixMountEntry and UnixMountPoint can be generated but currently used without cfg(unix),
so build fail on windows

This comment has been minimized.

Copy link
@sdroege

sdroege Jul 6, 2019

Member

Ok but that can be fixed by configuring that or not?

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jul 6, 2019

Author Member

Currently - not,
If I even with cfg_condition = "unix" on UnixMountEntry
in used without it use UnixMountEntry;
see https://github.com/gtk-rs/gio/compare/master...EPashkin:unixmount?expand=1

@@ -128,6 +128,26 @@ pub trait OutputStreamExt: 'static {
bytes: &glib::Bytes,
io_priority: glib::Priority,
) -> Box_<dyn future::Future<Output = Result<isize, Error>> + std::marker::Unpin>;

//#[cfg(any(feature = "v2_60", feature = "dox"))]
//fn writev<P: IsA<Cancellable>>(&self, vectors: /*Ignored*/&[&OutputVector], cancellable: Option<&P>) -> Result<usize, Error>;

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jul 6, 2019

Author Member

record GOutputVector contains only fields and need manual implementation.

This comment has been minimized.

Copy link
@sdroege

sdroege Jul 6, 2019

Member

Yes, and ideally with zero-cost conversion from std::io::IoVec :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 6, 2019

Looks good to me otherwise. Are there any news types in the .gir that we could generate now, and if so any reason to not add them while we're at it? :)

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jul 6, 2019

Seems no more new types:
GPollableReturn used only with GOutputVector
GDBusConnectionFlags used in GDBusConnection and we don't generate it now.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jul 6, 2019

DBusConnection generates almost all: https://github.com/gtk-rs/gio/compare/master...EPashkin:dbusconnection?expand=1
but IMHO it not usable without register_object

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 7, 2019

DBusConnection generates almost all: https://github.com/gtk-rs/gio/compare/master...EPashkin:dbusconnection?expand=1
but IMHO it not usable without register_object

Let's handle that in a separate PR.

Let's get this in then once the unix stuff is solved?

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jul 7, 2019

IMHO better solve problem UnixMountEntry and UnixMountPoint in separate PR too,
currently i has no idea how to fix this 😢

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 7, 2019

Ah I thought it's broken with this PR. If it needs to be enabled separately anyway, then sure let's get this in now and handle everything else separately. Thanks!

@sdroege sdroege merged commit 58bfd1d into gtk-rs:master Jul 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:eoan branch Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.