Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boxing in async func #232

Merged
merged 6 commits into from Aug 17, 2019
Merged

Fix boxing in async func #232

merged 6 commits into from Aug 17, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Aug 10, 2019

Part of gtk-rs/gir#807

Include generation of UnixMountEntry and UnixMountPoint

cc @GuillaumeGomez , @sdroege

src/auto/functions.rs Outdated Show resolved Hide resolved
@EPashkin EPashkin force-pushed the EPashkin:regen branch 2 times, most recently from 2326861 to 56983d7 Aug 14, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 14, 2019

There new problem with UnixMountPoint
its copy function was added later that object itself.

    #[cfg(any(feature = "v2_54", feature = "dox"))]
    pub fn g_unix_mount_point_copy(mount_point: *mut GUnixMountPoint) -> *mut GUnixMountPoint;

@GuillaumeGomez, @sdroege Can we add alternative function in sys that panics with message "copy for UnixMountPoint only implemented in Gio 2.54" ?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

@GuillaumeGomez, @sdroege Can we add alternative function in sys that panics with message "copy for UnixMountPoint only implemented in Gio 2.54" ?

Why not go via g_boxed_copy()?

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 14, 2019

@sdroege You right, g_boxed_copy can be used instead

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

@sdroege You right, g_boxed_copy can be used instead

We have some gir configuration for making use of that in autogenerated bindings btw, if that helps here

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 14, 2019

@sdroege Thanks for reminder, updated code

@EPashkin EPashkin force-pushed the EPashkin:regen branch 2 times, most recently from 93d47b3 to 0985d9b Aug 14, 2019
@EPashkin EPashkin force-pushed the EPashkin:regen branch from 0985d9b to 05e73da Aug 15, 2019
@EPashkin EPashkin force-pushed the EPashkin:regen branch from 05e73da to 508a877 Aug 15, 2019
@EPashkin EPashkin changed the title WIP: Fix boxing in async func Fix boxing in async func Aug 15, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 15, 2019

This PR is ready for review

src/auto/functions.rs Outdated Show resolved Hide resolved
src/auto/functions.rs Outdated Show resolved Hide resolved
src/auto/functions.rs Outdated Show resolved Hide resolved
@EPashkin EPashkin force-pushed the EPashkin:regen branch 4 times, most recently from dee3302 to 1b8891f Aug 16, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 16, 2019

Updated

src/auto/unix_mount_entry.rs Outdated Show resolved Hide resolved
src/unix_mount_point.rs Outdated Show resolved Hide resolved
src/unix_mount_point.rs Outdated Show resolved Hide resolved
@EPashkin EPashkin force-pushed the EPashkin:regen branch from 1b8891f to ed4a618 Aug 17, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 17, 2019

Updated

src/unix_mount_entry.rs Outdated Show resolved Hide resolved
src/unix_mount_point.rs Outdated Show resolved Hide resolved
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 17, 2019

Thanks, almost there I guess :)

EPashkin added 2 commits Aug 17, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 17, 2019

Thanks, will merge once CI is happy :)

@sdroege sdroege merged commit 1b2740a into gtk-rs:master Aug 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 17, 2019

Are there more regens needed for this one?

@EPashkin EPashkin deleted the EPashkin:regen branch Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.