Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subclassing Input/OutputStream #238

Merged
merged 6 commits into from Sep 4, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Aug 27, 2019

I'll also do the Seekable interface in a bit. Don't merge yet, but review :)

Also see #160

CC @BrainBlasted @GuillaumeGomez @EPashkin @fkrull

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Aug 27, 2019

Also support for gio::Seekable is there now. Next: wrappers for Read/Write/Seekable :)

Please review again! I consider the remaining comments above resolved, unless someone disagrees.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 27, 2019

@sdroege Thanks LGFM

@sdroege sdroege force-pushed the sdroege:streams branch from b550970 to 4f2547e Aug 28, 2019
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Aug 28, 2019

The last thing I'm going to add (probably tomorrow) is a WriteOutputStream (basically the inverse of the ReadInputStream), and then subclassing support for gio::IOStream. Then this here should be ready to be merged.

@sdroege sdroege force-pushed the sdroege:streams branch 2 times, most recently from 7d08a79 to a8ea462 Aug 29, 2019
src/subclass/io_stream.rs Outdated Show resolved Hide resolved
src/write_output_stream.rs Outdated Show resolved Hide resolved
@sdroege sdroege force-pushed the sdroege:streams branch 2 times, most recently from ea45f66 to e10d0d8 Sep 3, 2019
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Sep 3, 2019

Should be good for the final reviews now, functionality and tests are all implemented and passing.

@sdroege sdroege force-pushed the sdroege:streams branch from e10d0d8 to 924e7fe Sep 4, 2019
@sdroege sdroege force-pushed the sdroege:streams branch from 924e7fe to 1c32d88 Sep 4, 2019
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Sep 4, 2019

@sdroege LGFM, thanks for big work

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Sep 4, 2019

@sdroege LGFM, thanks for big work

Thanks for reviewing. I just added the Fixes #160 to the last two commit messages. Will merge once @GuillaumeGomez is also happy with it.

src/read_input_stream.rs Outdated Show resolved Hide resolved
@sdroege sdroege force-pushed the sdroege:streams branch from 1c32d88 to 1cc1dec Sep 4, 2019
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 4, 2019

Thanks!

@sdroege sdroege force-pushed the sdroege:streams branch from 1cc1dec to f3ef7a8 Sep 4, 2019
@sdroege sdroege merged commit 2ae4b82 into gtk-rs:master Sep 4, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.