Skip to content
This repository has been archived by the owner. It is now read-only.

Add support for subclassing Input/OutputStream #238

Merged
merged 6 commits into from Sep 4, 2019
Merged

Add support for subclassing Input/OutputStream #238

merged 6 commits into from Sep 4, 2019

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Aug 27, 2019

I'll also do the Seekable interface in a bit. Don't merge yet, but review :)

Also see #160

CC @BrainBlasted @GuillaumeGomez @EPashkin @fkrull

src/subclass/input_stream.rs Outdated Show resolved Hide resolved
src/subclass/input_stream.rs Outdated Show resolved Hide resolved
@sdroege
Copy link
Member Author

@sdroege sdroege commented Aug 27, 2019

Also support for gio::Seekable is there now. Next: wrappers for Read/Write/Seekable :)

Please review again! I consider the remaining comments above resolved, unless someone disagrees.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Aug 27, 2019

@sdroege Thanks LGFM

@sdroege
Copy link
Member Author

@sdroege sdroege commented Aug 28, 2019

The last thing I'm going to add (probably tomorrow) is a WriteOutputStream (basically the inverse of the ReadInputStream), and then subclassing support for gio::IOStream. Then this here should be ready to be merged.

src/subclass/io_stream.rs Outdated Show resolved Hide resolved
src/write_output_stream.rs Outdated Show resolved Hide resolved
@sdroege
Copy link
Member Author

@sdroege sdroege commented Sep 3, 2019

Should be good for the final reviews now, functionality and tests are all implemented and passing.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Sep 4, 2019

@sdroege LGFM, thanks for big work

@sdroege
Copy link
Member Author

@sdroege sdroege commented Sep 4, 2019

@sdroege LGFM, thanks for big work

Thanks for reviewing. I just added the Fixes #160 to the last two commit messages. Will merge once @GuillaumeGomez is also happy with it.

src/read_input_stream.rs Outdated Show resolved Hide resolved
src/subclass/input_stream.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 4, 2019

Thanks!

@sdroege sdroege merged commit 2ae4b82 into gtk-rs:master Sep 4, 2019
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants