This repository has been archived by the owner. It is now read-only.

Add support for subclassing Input/OutputStream #238

Merged

sdroege merged 6 commits into gtk-rs:master from sdroege:streams

Sep 4, 2019

Member

sdroege commented Aug 27, 2019

I'll also do the Seekable interface in a bit. Don't merge yet, but review :)

Also see #160

CC @BrainBlasted @GuillaumeGomez @EPashkin @fkrull

sdroege mentioned this pull request

Provide a way to use std::io::{Read,Write} and gio::{Input,Output}Stream interchangeably #160

Closed

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Outdated Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Outdated Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/output_stream.rs Outdated Show resolved Hide resolved

Member Author

sdroege commented Aug 27, 2019

Also support for gio::Seekable is there now. Next: wrappers for Read/Write/Seekable :)

Please review again! I consider the remaining comments above resolved, unless someone disagrees.

Member

EPashkin commented Aug 27, 2019

@sdroege Thanks LGFM

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Show resolved Hide resolved

Member Author

sdroege commented Aug 28, 2019

The last thing I'm going to add (probably tomorrow) is a WriteOutputStream (basically the inverse of the ReadInputStream), and then subclassing support for gio::IOStream. Then this here should be ready to be merged.

sdroege reviewed

View changes

src/read_input_stream.rs Show resolved Hide resolved

sdroege reviewed

View changes

src/subclass/io_stream.rs Outdated Show resolved Hide resolved

sdroege reviewed

View changes

src/write_output_stream.rs Outdated Show resolved Hide resolved

Member Author

sdroege commented Sep 3, 2019

Should be good for the final reviews now, functionality and tests are all implemented and passing.

EPashkin reviewed

View changes

src/read_input_stream.rs Show resolved Hide resolved

Member

EPashkin commented Sep 4, 2019

@sdroege LGFM, thanks for big work

Member Author

sdroege commented Sep 4, 2019

@sdroege LGFM, thanks for big work

Thanks for reviewing. I just added the Fixes #160 to the last two commit messages. Will merge once @GuillaumeGomez is also happy with it.

GuillaumeGomez reviewed

View changes

src/read_input_stream.rs Outdated Show resolved Hide resolved

GuillaumeGomez reviewed

View changes

src/subclass/input_stream.rs Outdated Show resolved Hide resolved

Member

GuillaumeGomez commented Sep 4, 2019

Thanks!

sdroege added 6 commits


          Add support for subclassing gio::InputStream

a9f7c99


          Add support for subclassing gio::OutputStream

c3b0b20


          Add support for implementing gio::Seekable in object subclasses

7da306d


          Add support for subclassing gio::IOStream

657f917


          Add a gio::InputStream wrapper around std::io::Read/Seek

b8be417

Fixes #160


          Add a gio::OutputStream wrapper around std::io::Write/Seek

f3ef7a8

Fixes #160

sdroege merged commit 2ae4b82 into gtk-rs:master

2 checks passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.