This repository has been archived by the owner. It is now read-only.
Add support for subclassing Input/OutputStream #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
reviewed
Aug 27, 2019
GuillaumeGomez
reviewed
Aug 27, 2019
GuillaumeGomez
reviewed
Aug 27, 2019
GuillaumeGomez
reviewed
Aug 27, 2019
GuillaumeGomez
reviewed
Aug 27, 2019
Also support for Please review again! I consider the remaining comments above resolved, unless someone disagrees. |
@sdroege Thanks LGFM |
GuillaumeGomez
reviewed
Aug 27, 2019
GuillaumeGomez
reviewed
Aug 27, 2019
The last thing I'm going to add (probably tomorrow) is a |
sdroege
reviewed
Aug 29, 2019
sdroege
reviewed
Aug 30, 2019
sdroege
reviewed
Aug 30, 2019
Should be good for the final reviews now, functionality and tests are all implemented and passing. |
EPashkin
reviewed
Sep 4, 2019
@sdroege LGFM, thanks for big work |
Thanks for reviewing. I just added the |
GuillaumeGomez
reviewed
Sep 4, 2019
GuillaumeGomez
reviewed
Sep 4, 2019
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'll also do the
Seekable
interface in a bit. Don't merge yet, but review :)Also see #160
CC @BrainBlasted @GuillaumeGomez @EPashkin @fkrull