Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignoring not generated property #241

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Sep 17, 2019

Part of gtk-rs/gtk#892

I hope that CI will pass without updating submodules

cc @GuillaumeGomez, @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 17, 2019

What's the point of this change, and why doesn't this generate the base-stream property as a read-only (or rather: construct-only) property? :)

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 17, 2019

It already has getter so ignoring was NOP
https://github.com/gtk-rs/gio/blob/master/src/auto/filter_input_stream.rs#L41
https://github.com/gtk-rs/gio/blob/master/src/auto/filter_output_stream.rs#L41
But with old version gir don't add "base_stream" to child builders

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 17, 2019

Ah I see. Makes sense! Will merge once CI is happy.

@sdroege sdroege merged commit 762b0ac into gtk-rs:master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:builder_interface_props branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.