Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsA<Cancellable> generic instead of concrete Option<&Cancellable> #242

Merged
merged 9 commits into from Sep 27, 2019

Conversation

@federicomenaquintero
Copy link
Contributor

federicomenaquintero commented Sep 24, 2019

Fixes #234

@federicomenaquintero

This comment has been minimized.

Copy link
Contributor Author

federicomenaquintero commented Sep 24, 2019

I just need to know if I should do the same on the relatively new subclass/*stream.rs :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Sep 24, 2019

IMHO InputStreamImplExt etc. don't need IsA<Cancelable> to minimize code size

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 24, 2019

I just need to know if I should do the same on the relatively new subclass/*stream.rs :)

See #234 (comment). Short answer is "no" :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 24, 2019

@federicomenaquintero the build is failing in all configurations it seems :)

@federicomenaquintero federicomenaquintero force-pushed the federicomenaquintero:cancellable-isa branch from 2cde16a to 5ebd9c2 Sep 24, 2019
@federicomenaquintero

This comment has been minimized.

Copy link
Contributor Author

federicomenaquintero commented Sep 24, 2019

Sorry, I forgot the tests! Fixed now.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 25, 2019

Sorry, I forgot the tests! Fixed now.

Some more are fixed now, but I think you forgot at least the futures code :) See https://travis-ci.org/gtk-rs/gio/jobs/589194656

Try running tests with --features=v2_60,futures

@federicomenaquintero federicomenaquintero force-pushed the federicomenaquintero:cancellable-isa branch from 5ebd9c2 to 8df11ed Sep 25, 2019
@federicomenaquintero

This comment has been minimized.

Copy link
Contributor Author

federicomenaquintero commented Sep 26, 2019

Uuuh... is that a cargo bug in the MacOS builds?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 27, 2019

Uuuh... is that a cargo bug in the MacOS builds?

thread 'main' panicked at 'index out of bounds: the len is 2 but the index is 2', src/tools/cargo/src/cargo/util/cpu.rs:152:29

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Is clearly a bug in cargo, yes. Feel like reporting it? :D

@sdroege sdroege merged commit 4fe407d into gtk-rs:master Sep 27, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@federicomenaquintero

This comment has been minimized.

Copy link
Contributor Author

federicomenaquintero commented Sep 27, 2019

Thanks! I'll try a run in my private repo with RUST_BACKTRACE=1 in the Travis environment to see if that gets useful info out of cargo panicking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.