Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-export glib types #249

Merged
merged 6 commits into from Oct 29, 2019
Merged

Don't re-export glib types #249

merged 6 commits into from Oct 29, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Oct 28, 2019

Depends on: gtk-rs/gir#866

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 28, 2019

src/subclass/mod.rs Outdated Show resolved Hide resolved
sdroege added 6 commits Oct 28, 2019
They only cause confusion: there is no gio::Error for example.
This makes it easier to use base-class APIs without first having to also
import the glib prelude on the user-side everywhere.
@sdroege sdroege force-pushed the sdroege:no-glib-reexports branch from 2ab1883 to e11b69a Oct 29, 2019
@sdroege sdroege changed the title WIP: Don't re-export glib types Don't re-export glib types Oct 29, 2019
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 29, 2019

Everybody happy with this PR before I prepare the other crates? :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 29, 2019

@sdroege Thanks, 👍

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 29, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Oct 29, 2019

👍

@sdroege sdroege merged commit 9a06d05 into gtk-rs:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.