Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen and prelude fixes #250

Merged
merged 2 commits into from Nov 3, 2019
Merged

Conversation

@sdroege
Copy link
Member

sdroege commented Nov 2, 2019

No description provided.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 2, 2019

Copy link
Member

GuillaumeGomez left a comment

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 2, 2019

Seems examples need fix first

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 2, 2019

@sdroege Thanks, 👍 after CI

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 2, 2019

About the failure: shouldn't we reexport all manual traits?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 2, 2019

It makes no sense to me to be able to have gio::Trait but not gio::TraitManual...

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 2, 2019
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 3, 2019

It makes no sense to me to be able to have gio::Trait but not gio::TraitManual...

Yes. We don't do that? I'll check tomorrow, I might be confused :)

@sdroege sdroege merged commit 70db962 into gtk-rs:master Nov 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege sdroege force-pushed the sdroege:n-export-prelude-everything branch from 1aff73b to d142f34 Nov 3, 2019
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 3, 2019

Oh I see. Yes the way how the prelude was re-exported was actually good and we should keep that. Sorry for the confusion :)

So only the regeneration here now. Will merge once green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.