Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GioFuture to not require fragile crate usage by all users anymore #258

Merged
merged 4 commits into from Nov 21, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Nov 20, 2019

See #257

Depends on gtk-rs/gir#875

Instead have our own small version of fragile::Fragile internally.

Also update manual futures code.
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 20, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 20, 2019

Also makes all generated futures code half the size or something :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 20, 2019

Looks good, but:

error[E0463]: can't find crate for `fragile`
  --> src\lib.rs:20:1
   |
20 | extern crate fragile;
   | ^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 20, 2019

and fragile still used in

pollable_input_stream.rs
pollable_output_stream.rs
socket.rs
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 20, 2019

Thanks! This depends on gtk-rs/glib#542 now too. There was some unneeded fragile usage left indeed, and I could also clean up some more code related to that now.

sdroege added 3 commits Nov 20, 2019
And clean up pollable in/output stream and socket GSource code.
@sdroege sdroege force-pushed the sdroege:gio-futures-without-fragile branch from 6154485 to c451de2 Nov 20, 2019
@sdroege sdroege merged commit 648e81a into gtk-rs:master Nov 21, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.