New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a copy of the Bytes passed to Resource::new_from_data() if it'… #60

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Nov 8, 2017

Show outdated Hide outdated src/resource.rs Outdated
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 8, 2017

Member

I followed the discussion on IRC and this seems to do what's expected. Just waiting for @EPashkin's confirmation.

Member

GuillaumeGomez commented Nov 8, 2017

I followed the discussion on IRC and this seems to do what's expected. Just waiting for @EPashkin's confirmation.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 8, 2017

Member

@sdroege Thanks.

@GuillaumeGomez 👍 from me

Member

EPashkin commented Nov 8, 2017

@sdroege Thanks.

@GuillaumeGomez 👍 from me

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Nov 8, 2017

Thanks @sdroege!

@GuillaumeGomez GuillaumeGomez merged commit 5463c9e into gtk-rs:master Nov 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment