New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async code generation #63

Merged
merged 7 commits into from Nov 26, 2017

Conversation

Projects
None yet
4 participants
@antoyo
Member

antoyo commented Nov 23, 2017

Do not merge this PR.
It is only an example of the code generated by this PR and I made this PR as requested by @sdroege.
This is generated using a newer version than the previous PR with the same name.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 23, 2017

Member

Is there a reason why all the async functions on GFile are not generated? Are they not supported yet for one reason or another?

Member

sdroege commented Nov 23, 2017

Is there a reason why all the async functions on GFile are not generated? Are they not supported yet for one reason or another?

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Nov 23, 2017

Member

@sdroege Sometimes, the async methods are not generated for GFile because a type is missing, this type could be the ProgressCallback as we discussed in Berlin.

Member

antoyo commented Nov 23, 2017

@sdroege Sometimes, the async methods are not generated for GFile because a type is missing, this type could be the ProgressCallback as we discussed in Berlin.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 23, 2017

Member

g_file_open_readwrite_async() for example should have no unknown types but does not appear here. Or basically 90% at least of all g_file_*_async() functions :)

Member

sdroege commented Nov 23, 2017

g_file_open_readwrite_async() for example should have no unknown types but does not appear here. Or basically 90% at least of all g_file_*_async() functions :)

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Nov 23, 2017

Member

@sdroege It is actually there:
the file is collapsed by default for some reason.

Member

antoyo commented Nov 23, 2017

@sdroege It is actually there:
the file is collapsed by default for some reason.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 23, 2017

Member

Oh, oops :) Nevermind then

Member

sdroege commented Nov 23, 2017

Oh, oops :) Nevermind then

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 25, 2017

Member

Seems good, thanks

Member

sdroege commented Nov 25, 2017

Seems good, thanks

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 25, 2017

Member

This is not strictly correct, but as those trait bounds don't affect the memory representation or behaviour here...
You can add them again by adding some parenthesis

Member

sdroege commented on src/auto/app_info.rs in 74d8bdd Nov 25, 2017

This is not strictly correct, but as those trait bounds don't affect the memory representation or behaviour here...
You can add them again by adding some parenthesis

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 26, 2017

Member

👍

Member

sdroege commented Nov 26, 2017

👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Ready to be merged then?

Member

GuillaumeGomez commented Nov 26, 2017

Ready to be merged then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2017

Member

It need regen with last gir

Member

EPashkin commented Nov 26, 2017

It need regen with last gir

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

@antoyo: Can you regen please so we can move forward?

Member

GuillaumeGomez commented Nov 26, 2017

@antoyo: Can you regen please so we can move forward?

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo
Member

antoyo commented Nov 26, 2017

@antoyo antoyo changed the title from [Do not merge] Async code generation to Async code generation Nov 26, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2017

Member

@antoyo Please update gir submodule too

Member

EPashkin commented Nov 26, 2017

@antoyo Please update gir submodule too

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo
Member

antoyo commented Nov 26, 2017

@EPashkin Done.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2017

Member

@antoyo Thanks.

Member

EPashkin commented Nov 26, 2017

@antoyo Thanks.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Thanks!

Member

GuillaumeGomez commented Nov 26, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit eedb68c into gtk-rs:master Nov 26, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

@EPashkin: Are we ready to move now? :)

Member

GuillaumeGomez commented Nov 26, 2017

@EPashkin: Are we ready to move now? :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Nov 26, 2017

@GuillaumeGomez IMHO yes

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Then let's go!

Member

GuillaumeGomez commented Nov 26, 2017

Then let's go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment