New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types #70

Merged
merged 2 commits into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Dec 9, 2017

cc @EPashkin @sdroege

It's required to be able to have the MountOperation working normally in gtk.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 9, 2017

This conflicting with #69

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 9, 2017

Indeed. If #69 is far from being merged, do you mind removing these new types from it please so I can move forward on gtk?

}
//fn connect_ask_password<Unsupported or ignored types>(&self, f: F) -> SignalHandlerId {
// Ignored flags: Gio.AskPasswordFlags

This comment has been minimized.

@sdroege

sdroege Dec 9, 2017

Member

Just add them :)

//}
//fn connect_ask_question<Unsupported or ignored types>(&self, f: F) -> SignalHandlerId {
// Empty ctype choices: *.CArray TypeId { ns_id: 0, id: 28 }

This comment has been minimized.

@sdroege

sdroege Dec 9, 2017

Member

That's just a GStrv, we support that?!

// unsafe { TODO: call ffi::g_file_start_mountable() }
//}
//fn stop_mountable<'a, 'b, 'c, P: Into<Option<&'a /*Ignored*/MountOperation>>, Q: Into<Option<&'b Cancellable>>, R: Into<Option<&'c /*Unimplemented*/AsyncReadyCallback>>, S: Into<Option</*Unimplemented*/Fundamental: Pointer>>>(&self, flags: /*Ignored*/MountUnmountFlags, mount_operation: P, cancellable: Q, callback: R, user_data: S) {
//fn stop_mountable<'a, 'b, 'c, P: Into<Option<&'a MountOperation>>, Q: Into<Option<&'b Cancellable>>, R: Into<Option<&'c /*Unimplemented*/AsyncReadyCallback>>, S: Into<Option</*Unimplemented*/Fundamental: Pointer>>>(&self, flags: /*Ignored*/MountUnmountFlags, mount_operation: P, cancellable: Q, callback: R, user_data: S) {

This comment has been minimized.

@sdroege

sdroege Dec 9, 2017

Member

@antoyo More async functions that are not called _async

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 9, 2017

Ok, I think this PR is ready. Just waiting to know if @EPashkin's PR will take long before getting merged or not.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 9, 2017

It seems don't conflict with my PR, so I rebase it after this merged

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 9, 2017

Thanks! I'm just waiting for the CIs and then I merge.

@GuillaumeGomez GuillaumeGomez merged commit a689359 into gtk-rs:master Dec 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 9, 2017

@GuillaumeGomez
CI passed.
Also I reminder you about docs.

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:new-types branch Dec 9, 2017

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 9, 2017

What about docs?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 9, 2017

Please, regen docs for gtk-rs.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 9, 2017

Sure, I just finish my gtk PR first and here we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment