New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lots of Socket related bindings #78

Merged
merged 9 commits into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Feb 7, 2018

Depends on gtk-rs/glib#290

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 7, 2018

Last commit "Add SocketClient" don't contains regen with removing *_async

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

Last commit "Add SocketClient" don't contains regen with removing *_async

Thanks, fixed

fn lookup_by_name_async<'a, P: Into<Option<&'a Cancellable>>, Q: FnOnce(Result<Vec<InetAddress>, Error>) + Send + 'static>(&self, hostname: &str, cancellable: P, callback: Q);
#[cfg(any(feature = "v2_34", feature = "dox"))]
fn lookup_records_async<'a, P: Into<Option<&'a Cancellable>>, Q: FnOnce(Result<Vec<glib::Variant>, Error>) + Send + 'static>(&self, rrname: &str, record_type: ResolverRecordType, cancellable: P, callback: Q);

This comment has been minimized.

@EPashkin

EPashkin Feb 7, 2018

Member

No type this function

#[cfg(any(feature = "v2_34", feature = "dox"))]
use ResolverRecordType;

This comment has been minimized.

@EPashkin

EPashkin Feb 7, 2018

Member

also #[cfg(any(feature = "v2_34", feature = "dox"))]use glib; needed or glib::Variant with fixing type

This comment has been minimized.

@sdroege

sdroege Feb 7, 2018

Member

Thanks, fixed

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 7, 2018

All manual code looks good and PR compiled for windows.
@sdroege Thanks.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

@GuillaumeGomez Should be good to go then, after the GLib one is merged :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 7, 2018

I restart CIs.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 8, 2018

CI happy :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 8, 2018

Then so am I. 😃

@GuillaumeGomez GuillaumeGomez merged commit 37c2a08 into gtk-rs:master Feb 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment