New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up Socket::create_source() implementation #79

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Feb 8, 2018

We need to provide a callback, etc. for this function to be useful.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 8, 2018

@sdroege Looks good.
You seems forgot to add Gir.toml changes.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 8, 2018

Indeed, thanks :) will add later

Fix-up Socket::create_source() implementation
We need to provide a callback, etc. for this function to be useful.
@sdroege

This comment has been minimized.

Member

sdroege commented Feb 8, 2018

Updated

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 9, 2018

@sdroege Thanks
👍

@GuillaumeGomez GuillaumeGomez merged commit 18244f3 into gtk-rs:master Feb 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment