New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build #80

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Feb 9, 2018

Fix doc builds found in gtk-rs/gtk#622

cc @GuillaumeGomez , @sdroege

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 9, 2018

Great, thanks!

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 9, 2018

Seems comments need be moved to lgpl-docs.
Any comment about text or format?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 9, 2018

Not really. Should I?

@EPashkin EPashkin referenced this pull request Feb 9, 2018

Merged

Add manual docs for Gio #42

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 9, 2018

Strange: docs generated, but no docs for IntoRawFd or no link from new_from_fd for me (windows).
Also link for windows specific IntoRawSocket wrong (maybe because I build under nightly).
Finally no This is supported on Windows only. on new_from_socket like on https://doc.rust-lang.org/std/os/windows/io/trait.IntoRawSocket.html 😭

So doc comments only stays in source file.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 9, 2018

Yes, world is a bitch. :'(

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 9, 2018

Anyway CI passed

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 9, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 2fdc6d2 into gtk-rs:master Feb 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_doc_build branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment