New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stub traits under feature="dox" public to include in doc #81

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Feb 9, 2018

Part of #80

cc @GuillaumeGomez

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 9, 2018

Reason that trait doc not generated because it was not public 😉
@GuillaumeGomez can you check doc on linux? Seems text in lgpl-docs need some fixes: currently it shows as one line.

<div class='docblock'><p>This is stub for doc generation
<a href="https://doc.rust-lang.org/std/os/unix/io/trait.IntoRawFd.html">Actual docs</a></p>
</div>
@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 10, 2018

I can't find this sentence anywhere in the generated docs with a grep...

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 10, 2018

You looked for This is stub for doc generation?
Link pages in target\doc\gio\socket directory, actual pages in target\doc\gio\prelude but there too many pages.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 14, 2018

@GuillaumeGomez I just remind you about this PR

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 14, 2018

Woups sorry!

@GuillaumeGomez GuillaumeGomez merged commit 16c2077 into gtk-rs:master Feb 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_sub_trait_docs branch Feb 14, 2018

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 14, 2018

@GuillaumeGomez Is sample HMTL code was good for you?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 14, 2018

Ah sorry, forgot to comment. Yes it was. At least didn't see any issue.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 15, 2018

Thanks for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment