New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate File{Input,Output,IO}Stream automatically #86

Merged
merged 2 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@sdroege
Member

sdroege commented Feb 22, 2018

No description provided.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 22, 2018

@MathieuDuponchelle

lgtm, thanks!

Gir.toml Outdated
@@ -64,15 +64,15 @@ generate = [
"Gio.ThemedIcon",
"Gio.TlsCertificate",
"Gio.TlsCertificateFlags",
"Gio.FileIOStream",
"Gio.FileInputStream",
"Gio.FileOutputStream",

This comment has been minimized.

@EPashkin

EPashkin Feb 22, 2018

Member

Please insert it in such a way that the sorting is preserved

This comment has been minimized.

@sdroege

sdroege Feb 22, 2018

Member

Like this? The list is unordered already, maybe someone wants to order it in general :)

This comment has been minimized.

@EPashkin

EPashkin Feb 22, 2018

Member

generate array was sorted alphabetically. I missed that items added after SimplePermission was not in order.
Can you resort it?

This comment has been minimized.

@sdroege

sdroege Feb 22, 2018

Member

Done, I hope it's in the correct order now :)

// Licensed under the MIT license, see the LICENSE file or <http://opensource.org/licenses/MIT>
// This file was generated by gir (https://github.com/gtk-rs/gir @ bd67955)
// from gir-files (https://github.com/gtk-rs/gir-files @ db49619)
// DO NOT EDIT

This comment has been minimized.

@EPashkin

EPashkin Feb 22, 2018

Member

Cool changes 😉

This comment has been minimized.

@sdroege

sdroege Feb 22, 2018

Member

Yes, boring :(

This comment has been minimized.

@MathieuDuponchelle

MathieuDuponchelle Feb 22, 2018

Contributor

Would be sweet if this info could be output in a separate file instead, with the option to version control it (or not) left to the repo maintainer

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 22, 2018

@sdroege Thanks.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 22, 2018

Then let's get it in, almost no manual code left for async functions then :)

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 23, 2018

@GuillaumeGomez anything missing from your side?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 23, 2018

Nope, all good for me as well! Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 473095e into gtk-rs:master Feb 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment