New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Tls bindings: missing files #87

Merged
merged 1 commit into from Feb 24, 2018

Conversation

Projects
None yet
3 participants
@MathieuDuponchelle
Contributor

MathieuDuponchelle commented Feb 23, 2018

These went missing from #83

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 23, 2018

@MathieuDuponchelle Please, update gir-files submodule: it was mistakenly reverted back in #86.
Generated file must have https://github.com/gtk-rs/gir-files @ 77d1f70 in header.

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 23, 2018

I'm a bit confused, is the new commit what you expect ?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 23, 2018

Thanks, you done it as I think.
Lately I began to think that separate commits for submodule update is not necessary if main changes contains in single commit.

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 23, 2018

Lately I began to think that separate commits for submodule update is not necessary if main changes contains in single commit.

Would really be nice if update didn't change file headers IMO

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 23, 2018

Also, not sure what the failing tests are about, any idea?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 23, 2018

@GuillaumeGomez I propose to merge this, we have my commit to check rustdoc fix

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 23, 2018

About version, maybe we need change versioning to adding single file with it? But this way we be not sure with which version file generated actually, specially in PR's
So currently I prefer current versioning.
@GuillaumeGomez, @sdroege Maybe you have better idea?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 23, 2018

I must admit that I don't have an opinion in here. Otherwise, the PR seems good to me as well so I'll wait for the debate to end before merging it. ;)

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 24, 2018

I must admit that I don't have an opinion in here. Otherwise, the PR seems good to me as well so I'll wait for the debate to end before merging it. ;)

You shouldn't wait :) This shouldn't be blocked by a debate, by the way can i find you folks on an IRC channel? I'm on gtk-rs in on mozilla's servers, and rust on gimpnet, but if you're also there I don't recognize user names :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 24, 2018

I'm imperio there (on both IRC channels). And since you seem to be french, I'm also on #rust-fr (on mozilla server).

So since @EPashkin gave the go, I'll merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit cf92fc0 into gtk-rs:master Feb 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 24, 2018

I'm imperio there

That was not my first guess :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 24, 2018

I would assume so. Someone took the pseudo on github so I went for this one. :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment