New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind IOErrorEnum #91

Merged
merged 1 commit into from Mar 3, 2018

Conversation

Projects
None yet
4 participants
@ystreet
Contributor

ystreet commented Mar 3, 2018

No description provided.

@sdroege

This comment has been minimized.

Member

sdroege commented Mar 3, 2018

Are some variants of the enum only available on some platforms? I can't remember

Otherwise looks good to me

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Mar 3, 2018

Strange travis error. I restarted the build.

@ystreet

This comment has been minimized.

Contributor

ystreet commented Mar 3, 2018

@sdroege There's no #if guards around any of the values in the gio C headers so I think the values are available everywhere however they may not exactly be used everywhere but that's not our problem :)

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 3, 2018

LGFM

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Mar 3, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit ed38871 into gtk-rs:master Mar 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ystreet ystreet deleted the ystreet:ioerror branch Mar 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment