New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single_version_file option #92

Merged
merged 3 commits into from Mar 4, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Mar 3, 2018

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Mar 3, 2018

Aren't a lot of files missing in here? All files into the auto folder should have their headers updated, no?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 3, 2018

All changes is same, I do full regen after gir merged.
Currently working on travis checks

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 3, 2018

Updated travis to check regen only on first build

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 4, 2018

Updated with final regen

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 4, 2018

Added delay before invoking in async tests.
Them stalled sometimes: https://travis-ci.org/gtk-rs/gio/builds/348980232

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Mar 4, 2018

Next reviews will be so much easier. :D

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 4, 2018

Strange, delay not works, I remove it then.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 4, 2018

@GuillaumeGomez, can you restart travis? Or we can merge at current state?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Mar 4, 2018

Restarted.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Mar 4, 2018

@GuillaumeGomez CI happy

@GuillaumeGomez GuillaumeGomez merged commit 7ffe5b3 into gtk-rs:master Mar 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:single_version_file branch Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment