Allow tweaking visibility #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
commented
Dec 26, 2021
|
You can see the glib crate re-generated with the changes of this PR at gtk-rs/gtk-rs-core@27e611d |
lucab
reviewed
Dec 26, 2021
bilelmoussaoui
force-pushed
the
bilelmoussaoui/func-visibility
branch
24 times, most recently
from
d755fb0
to
ff7d3f9
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/func-visibility
branch
from
ff7d3f9
to
4f1da8a
Compare
|
Updated & added documentation to the book |
sdroege
approved these changes
Dec 30, 2021
bilelmoussaoui
force-pushed
the
bilelmoussaoui/func-visibility
branch
from
4f1da8a
to
fcacdc8
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/func-visibility
branch
from
fcacdc8
to
495ea49
Compare
|
Thanks for landing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to tweak the visibility of functions/enums/flags & also objects/records. For global functions that are marked as non-public, they also have a
#[allow(dead_code)]guard added to avoid any clippy complaints.Fixes #1238
cc @lucab