Bounds #317

Merged
merged 4 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Feb 10, 2017

Add multiple lifetimes for Into bound. Affected glib, gio, no uncommented changes in gtk

-    pub fn set_comment<'a, T: Into<Option<&'a str>>, U: Into<Option<&'a str>>>(&self, group_name: T, key: U, comment: &str) -> Result<(), Error> {
+    pub fn set_comment<'a, 'b, T: Into<Option<&'a str>>, U: Into<Option<&'b str>>>(&self, group_name: T, key: U, comment: &str) -> Result<(), Error> {

Fixed generation private and unused StyleContext::to_string

     #[cfg(feature = "v3_20")]
-    fn to_string(&self, flags: StyleContextPrintFlags) -> String {
+    pub fn to_string(&self, flags: StyleContextPrintFlags) -> String {

@GuillaumeGomez, IMHO regen affected can wait until we done with Into

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 10, 2017

Member

You extended lifetime usage: AWESOME!!! It'll make its usage so much easier/better! With this it'll be easier to add Into for all Option types.Thanks a lot!

All good for me, merge when you're ready.

Member

GuillaumeGomez commented Feb 10, 2017

You extended lifetime usage: AWESOME!!! It'll make its usage so much easier/better! With this it'll be easier to add Into for all Option types.Thanks a lot!

All good for me, merge when you're ready.

@EPashkin EPashkin merged commit a4dcf95 into gtk-rs:master Feb 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:bounds branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment