New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _POSIX_C_SOURCE feature test macro. #576

Merged
merged 1 commit into from Apr 1, 2018

Conversation

Projects
None yet
2 participants
@tmiasko
Contributor

tmiasko commented Apr 1, 2018

When feature test macro is explicitly defined, the implicit defaults are no
longer provided. While we don't need any more features than requested, this is
not necessarily true of other libraries which may in fact assume that defaults
will be always available.

Instead of defining _POSIX_C_SOURCE to get appropriate functionality from
printf on MinGW, just define __USE_MINGW_ANSI_STDIO directly.

Also include manual header first so that it can be free to customize macro
definitions, before other headers are processed.

Remove _POSIX_C_SOURCE feature test macro.
When feature test macro is explicitly defined, the implicit defaults are no
longer provided. While we don't need any more features than requested, this is
not necessarily true of other libraries which may in fact assume that defaults
will be always available.

Instead of defining _POSIX_C_SOURCE to get appropriate functionality from
printf on MinGW, just define __USE_MINGW_ANSI_STDIO directly.

Also include manual header first so that it can be free to customize macro
definitions, before other headers are processed.
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 1, 2018

Member

@tmiasko Thanks

Member

EPashkin commented Apr 1, 2018

@tmiasko Thanks

@EPashkin EPashkin merged commit 74a37af into gtk-rs:master Apr 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Merge pull request #576 from tmiasko/remove-posix-c-source
Remove _POSIX_C_SOURCE feature test macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment